Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: fix some unstable tests in global stats (#23502) #24033

Closed
wants to merge 2 commits into from
Closed

statistics: fix some unstable tests in global stats (#23502) #24033

wants to merge 2 commits into from

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Apr 14, 2021 •
edited
Loading

cherry-pick #23502 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/24033

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/24033:release-5.0-b1b375e7ef0e

What problem does this PR solve?

Fix some unstable tests in global stats.
You can see these unstable tests in here.

What is changed and how it works?

  • Let the test TestDropPartitionStats execute linearly
  • fix some mistakes in testMergeTopN

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

@Reminiscent @ti-srebot
cherry pick pingcap#23502 to release-5.0
eddddb2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested review from a team as code owners April 14, 2021 16:53
@ti-srebot ti-srebot requested review from XuHuaiyu and removed request for a team April 14, 2021 16:53
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot mentioned this pull request Apr 14, 2021
Merged
@ti-srebot ti-srebot added sig/execution SIG execution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.0-cherry-pick labels Apr 14, 2021
@ti-srebot ti-srebot added this to the v5.0.0 ga milestone Apr 14, 2021
@ti-srebot
Copy link
Contributor Author

@Reminiscent you're already a collaborator in bot's repo.

@lysu
Copy link
Contributor

lysu commented Apr 15, 2021

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 15, 2021
@lysu
Copy link
Contributor

lysu commented Apr 15, 2021

@zhouqiang-cl maybe need a label, this PR fix release-5.0 test unstable problem too

@lysu
Copy link
Contributor

lysu commented Apr 15, 2021

@qw4990 ptal

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lysu
  • qw4990

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 15, 2021
@lysu
Copy link
Contributor

lysu commented Apr 15, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: eddddb2

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 15, 2021
@lysu lysu added the cherry-pick-approved Cherry pick PR approved by release team. label Apr 15, 2021
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Apr 15, 2021
@lysu
Copy link
Contributor

lysu commented Apr 15, 2021

/run-unit-test

1 similar comment
@lysu
Copy link
Contributor

lysu commented Apr 15, 2021

/run-unit-test

@lysu
Copy link
Contributor

lysu commented Apr 15, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 15, 2021
@ti-chi-bot
Copy link
Member

@ti-srebot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wshwsh12 wshwsh12 removed their request for review June 3, 2021 05:07
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 4, 2021
@guo-shaoge guo-shaoge removed the request for review from XuHuaiyu June 10, 2021 02:18
@eurekaka eurekaka removed their request for review June 21, 2021 08:00
@winoros winoros removed the request for review from a team June 21, 2021 09:04
@Reminiscent
Copy link
Contributor

The unstable test has been skipped via #24003. So close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@rebelice rebelice Awaiting requested review from rebelice

Assignees

@Reminiscent Reminiscent

Labels
cherry-pick-approved Cherry pick PR approved by release team. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/execution SIG execution size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/5.0-cherry-pick
Projects
None yet
Milestone
v5.0.0 ga
Development

Successfully merging this pull request may close these issues.
6 participants
@ti-srebot @lysu @ti-chi-bot @Reminiscent @qw4990 @zhouqiang-cl